Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace calls to Form::text #16082

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

Copy link

what-the-diff bot commented Jan 16, 2025

PR Summary

  • Moved to Standard HTML Input Element: The former Laravel Form::text has been replaced with the basic HTML <input> element in multiple files to align with better HTML practices and standardize form structure across the project. This base code change will affect various settings views.

  • Form Field Attributes Updated: Each form field has updated attributes such as 'class', 'name', 'type', 'value', along with accessibility features like 'aria-label'. The change maintains the same functionality while improving accessibility and individual form field identification.

  • Consistent Error Messaging: The display of error messages keeps its original structure despite the change of form elements, ensuring users receive necessary feedback upon incorrect inputs.

  • Improvement in Alert_Interval, Alert_Threshold and Other Inputs: Important form inputs such as alert_interval, alert_threshold, among others, have been adjusted to make sure they work as expected with the new <input> structure.

  • Updated Validation Mechanism: The previous way of applying validation and fetching old values has been preserved in the new input fields, ensuring data input integrity.

  • Modifications in Form Structures: The structure of multiple forms, such as localization, purge-form, saml, security, setup user, status labels, and suppliers has improved for better readability and user experience.

  • Attributes and Layout Enhancements: Other minor edits include adding maxlength attributes, altering error layouts for better user experience, and ensuring consistent formatting within the code for high readability.

# Conflicts:
#	resources/views/settings/alerts.blade.php
@marcusmoore marcusmoore marked this pull request as ready for review January 22, 2025 23:03
@marcusmoore marcusmoore requested a review from snipe as a code owner January 22, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant