Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fragment to uploads for redirect #16105

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jan 21, 2025

This is just a nice UI touch to redirect the user back to the #files tab after uploading or deleting a file.

Copy link

what-the-diff bot commented Jan 21, 2025

PR Summary

  • Enhanced Redirection Process
    In various elements such as Accessories, AssetModels, Assets, Components, Consumables, and Users, the redirection method after dealing with file operations has been modified to use .withFragment('files'). This results in a more efficient redirection process.

  • Harmonized View ID Naming
    The ID name of the tab in the view file has been updated from uploads to files, providing consistency with the new fragment usage.

  • Optimized File Upload Request Process
    Unnecessary debug logs from the UploadFileRequest class have been removed, resulting in a cleaner and more efficient request process.

@snipe snipe merged commit 8db8d4b into develop Jan 21, 2025
9 checks passed
@snipe snipe deleted the use_url_fragment_for_file_uploads branch January 21, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant