Add some safeties around charset detection and transliteration #16123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some environments, you need to specify character sets for
iconv()
in UPPERCASE. So this adds that.In addition, sometimes the character set transformation can fail (such as when it's not in uppercase), and while that only usually raises an
E_NOTICE
, Laravel will tend to transform those notices into Exceptions, so we need to catch those.And finally, if you don't happen to have
iconv
installed at all, we should gracefully detect that and default to the 'regular' behavior.