Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace calls to Form::hidden #16140

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Replace calls to Form::hidden #16140

merged 3 commits into from
Jan 27, 2025

Conversation

marcusmoore
Copy link
Collaborator

This PR replaces calls to Form::hidden with either plain html or, in one case, the @csrf directive.

Pages Affected

Copy link

what-the-diff bot commented Jan 27, 2025

PR Summary

  • Switched to Standard HTML for Form Fields
    The form fields in our settings module were previously using a method Form::hidden which was a bit complex. The pull request has replaced these with the standard HTML <input type="hidden"> fields, providing simpler and more widely used code.

  • Improvement in Security for Backup Generation Button
    Previously, the way our backup generation button in settings handled the CSRF (Cross-Site Request Forgery) token input was by using Form::hidden. Now, the PR updates this to use the @csrf directive, simplifying the code and enhancing the reliability of this input handling.

@snipe snipe merged commit fd60ce1 into snipe:develop Jan 27, 2025
8 of 9 checks passed
@marcusmoore marcusmoore deleted the chore/sc-28233 branch January 27, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants