Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Translation strings to General and Branding Settings #16150

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Jan 29, 2025

In the General Settings:
Adds translation for login_note_placeholder
Adds translation for test_mail
Adds translation for status_label_name
Adds translation for depreciation_method
Adds translation for linear_depreciation
Adds translation for half_1 and half_2

In Branding Settings:
Adds translations for logo_option_types
Adds translation for super_admin_only
Adds translation for custom_css_placeholder
Adds translation for footer_text_placeholder

Copy link

what-the-diff bot commented Jan 29, 2025

PR Summary

  • Enhancement in Language Support
    The team has added English translations for terms related to depreciation in the general.php file. This includes a variety of terms such as 'depreciation method', 'linear depreciation', and 'half-year convention' (that we have two forms of, one that's always applied and another applied conditionally).

  • Settings Language Files Updated
    There are now placeholders for a variety of features such as custom CSS, optional footer text, login note, test mail, status label name, and super admin only settings.

  • Updating Views for Better Localization
    Another impactful change implemented involves updating branding.blade.php and general.blade.php views to take advantage of the new translations. The hardcoded text in these files has been replaced with translatable strings for fields such as 'brand', 'custom_css', 'support_footer', 'version_footer', and 'footer_text'. They've also transformed the drop-down menu for the depreciation method so that it will be populated with translated values.

  • User Interface and Accessibility Improvements
    This change is for the better in terms of user interaction and understanding. By providing translations for existing labels and placeholders, users can navigate and utilize settings with more ease and clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant