Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #16208 - don't call preg_split() with a null #16209

Merged

Conversation

uberbrady
Copy link
Collaborator

PHP has made the poor decision to start throwing deprecation warnings if you call preg_split() with a null as the second parameter - behavior that has been completely permissible for the last decade or more in PHP.

These somewhat pointless changes should silence those deprecation warnings and allow us to remain compatible with the latest versions of PHP.

Copy link

what-the-diff bot commented Feb 6, 2025

PR Summary

  • Enhancement in SettingsSamlRequest.php File Handling
    The updates made have enhanced the handling of empty inputs in SettingsSamlRequest.php file. It now provides a default value of an empty string when retrieving saml_custom_settings, thus improving the method's reliability and safety.

  • Improvements in CustomField.php File Error Prevention
    Changes in the CustomField.php file have resulted in better error prevention. It now uses a null coalescing operator when processing field_values, which effectively eliminates potential errors that may arise from undefined values.

  • Robustness Enhancement in Saml.php File
    The handling of null values in the Saml.php file has been improved. A null coalescing operator is now used when splitting saml_custom_settings, ensuring better robustness of the software against such values.

@snipe snipe merged commit b48704b into snipe:develop Feb 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants