Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds ternaries on check in/out hardware notifications #16212

Merged

Conversation

Godmartinz
Copy link
Collaborator

This adds ternaries for locations and asset status before pulling their names for notifications.

Copy link

what-the-diff bot commented Feb 6, 2025

PR Summary

  • Updated null coalescing for asset status

    • The way we handle cases when asset status is not available has been improved. This will prevent any errors that occur when the asset status is missing.
  • Improved location name handling

    • We’ve improved how the system deals with missing location names. Now, when a location name is not available, the system won't give an error anymore.
  • Consistently applied null checks

    • We’ve ensured that the checks for missing location names are consistently applied across multiple functions. This enhances the stability of the operations and avoids any potential errors due to missing values.

@Godmartinz Godmartinz changed the title adds ternaries on check in/oout hardware notifications adds ternaries on check in/out hardware notifications Feb 6, 2025
@snipe snipe changed the base branch from master to develop February 10, 2025 22:28
@snipe snipe merged commit b54d68e into snipe:develop Feb 10, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants