Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Trans Choice in Unaccepted Asset Email #16237

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akemidx
Copy link
Collaborator

@akemidx akemidx commented Feb 12, 2025

Fixed an issue where the body of an email did not pluralize items when multiple items were unaccepted.

Screenshot 2025-02-11 at 8 02 32 PM

Copy link

what-the-diff bot commented Feb 12, 2025

PR Summary

  • Enhanced String Localization in Notification Emails
    The notification email system's 'item_checked_reminder' message has been improved to handle singular and plural forms more effectively. This was achieved through a new pipe-separated string approach.

  • Improved Grammatical Accuracy in Notification Messages
    Fixed a small grammatical issue in the 'unaccepted_asset_reminder' string. Now it uses 'Asset(s)' instead of 'Asset', appropriately representing both single and multiple assets.

  • Optimized Pluralization in Notification Messages
    Adjusted the way the 'item_checked_reminder' message is utilized in the notification system. Instead of the previous method, we now use the trans_choice function, which is more effective in handling pluralization.

  • Improved Readability in Notification Templates
    Addressed a minor formatting issue inside our notification email templates where the greeting line had incorrect spacing. After this fix, the greeting line is more readable and visually appealing.

@@ -88,7 +88,7 @@
'upcoming-audits' => 'There is :count asset that is coming up for audit within :threshold days.|There are :count assets that are coming up for audit within :threshold days.',
'user' => 'User',
'username' => 'Username',
'unaccepted_asset_reminder' => 'You have Unaccepted Assets.',
'unaccepted_asset_reminder' => 'You have Unaccepted Asset(s).',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This weeks awkward to me - I think we'd want to trans_choice the subject here as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants