Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Form::open and Form::close pt2 #16242

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

marcusmoore
Copy link
Collaborator

This PR replaces Form::open and Form::close on the following pages:

Copy link

what-the-diff bot commented Feb 12, 2025

PR Summary

  • Switched to Standard HTML Form Tags
    Swapped the existing Form::open and Form::close method calls with standard HTML <form> tags in a few specified files.

  • Included Form Details
    Added the action and accept-charset attributes to the <form> tags. The action attribute outlines the route where the form should be submitted while accept-charset specifies the character set being used.

  • Updated File Upload Attribute
    The way files are uploaded via forms in audit.blade.php and quickscan-checkin.blade.php has been improved by updating the multipart/form-data attribute.

  • Consistency in Closing Form Tags
    Across the modified files, care has been taken to ensure that the opening and closing of <form> tags is consistent, thereby maintaining code hygiene and readability.

@snipe snipe merged commit 3d07709 into snipe:develop Feb 18, 2025
9 checks passed
@marcusmoore marcusmoore deleted the chore/migrate-form-open-pt2 branch February 18, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants