Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop Python 3.8 support. Add Python 3.13 support. Update CI/dev dependencies. #197

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

Daverball
Copy link
Collaborator

Might also be worth to move the mypy config from setup.cfg to pyproject.toml.

@Daverball
Copy link
Collaborator Author

I don't exactly know what causes it, but for some reason installing flake8-use-pathlib with some of the other updated dependencies breaks a small number tests in 3.12+

I decided to get rid of flake8-use-pathlib and instead use flake8-bugbear for the regression test. It technically should be a more reliable test, since it's a more complex plugin, accessing more nodes.

@Daverball

This comment was marked as resolved.

@Daverball

This comment was marked as resolved.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.5%. Comparing base (7621d51) to head (83657c0).
Report is 87 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #197     +/-   ##
=======================================
- Coverage   98.7%   96.5%   -2.2%     
=======================================
  Files          3       3             
  Lines        482     966    +484     
=======================================
+ Hits         476     933    +457     
- Misses         6      33     +27     
Files with missing lines Coverage Δ
flake8_type_checking/checker.py 96.3% <100.0%> (-2.3%) ⬇️
flake8_type_checking/constants.py 100.0% <ø> (ø)

... and 1 file with indirect coverage changes

@Daverball Daverball requested a review from sondrelg December 12, 2024 12:50
@Daverball
Copy link
Collaborator Author

Looks like Codecov was broken for a while due to the outdated action. It just happened to complain loudly in some cases now, where previously it failed silently. The new version seems to work even for tokenless upload with rate limits.

Copy link
Member

@sondrelg sondrelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Feel free to move the mypy config too 👍

@Daverball Daverball merged commit 40c43b5 into snok:main Dec 13, 2024
6 checks passed
@Daverball Daverball deleted the chore/-py38+py313 branch December 13, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants