Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make sure to visit returns not just the argument annotations #198

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

Daverball
Copy link
Collaborator

Closes #185

Also fixes the same bug for Pydantic and singledispatch

@Daverball Daverball merged commit eef57df into snok:main Dec 13, 2024
6 checks passed
@Daverball Daverball deleted the fix/fastapi branch December 13, 2024 10:44
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.8%. Comparing base (7621d51) to head (a77a597).
Report is 88 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #198     +/-   ##
=======================================
- Coverage   98.7%   96.8%   -2.0%     
=======================================
  Files          3       3             
  Lines        482     970    +488     
=======================================
+ Hits         476     939    +463     
- Misses         6      31     +25     
Files with missing lines Coverage Δ
flake8_type_checking/checker.py 96.5% <100.0%> (-2.1%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for FastAPI return types.
1 participant