Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestLabelModelAdvanced fails when changing cardinality #1631

Closed
talolard opened this issue Feb 15, 2021 · 0 comments · Fixed by #1637
Closed

TestLabelModelAdvanced fails when changing cardinality #1631

talolard opened this issue Feb 15, 2021 · 0 comments · Fixed by #1637
Assignees

Comments

@talolard
Copy link

talolard commented Feb 15, 2021

Issue description

I run the tests in TestLabelModelAdvanced.
The setUp is

    def setUp(self) -> None:
        """Set constants for the tests."""
        self.m = 10  # Number of LFs
        self.n = 10000  # Number of data points
        self.cardinality = 2  # Number of classes

That test passes.

If I change cardinaltiy to 3,4 ... the tests fail.

Code example/repro steps

See above

Expected behavior

The tests should pass regardless of cardinality

System info

  • How you installed Snorkel (conda, pip, source): source
  • Build command you used (if compiling from source): tox
  • OS: Ubuntu
  • Python version: 3.6.9
  • Snorkel version:'0.9.6+dev'

Additional context

Relates to #1625 and #1629 .

When I run this test on the classes I've added in #1629 they fail, and I don't know if it's just because of my code or also because the test is "specific"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants