Modify test to permit higher cardinality cases for label model #1637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The test_label_model_basic and test_label_model_sparse tests are specific to binary class; increasing the cardinality of the problem beyond 2 (which increases the number of parameters) prevents the tests from passing.
This change modifies the tests to use average error (which is invariant to the number of parameters) instead of maximum error (which makes higher-cardinality tests increasingly difficult).
Related issue(s)
Fixes #1631
Test plan
I ran the scenario in #1631 with cardinality 3,4,...,10 and the tests pass.
Checklist
Need help on these? Just ask!
tox -e complex
and/ortox -e spark
if appropriate.