Skip to content

Commit

Permalink
Aligns copy corrects potentially confusing naming
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-afedorov committed Jul 25, 2019
1 parent aae28b8 commit 6f739f0
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 12 deletions.
4 changes: 4 additions & 0 deletions migrations/v1_8_1-v1_8_2.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,7 @@ Similarly to the Config Data Connector, the CloudTrail connector now has a "`aws
## Azure Log Data Connections

The Azure Log data connection table will now refer correctly to the `azure_log` module. In order to update your v1.7 tables, please change the comment to include "`module: azure_log`".

## AWS Asset Ingestion now Inventory

We've renamed the `aws_asset_ingest` Data Connector to align with the others as `aws_inventory`.
6 changes: 3 additions & 3 deletions src/connectors/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
from . import azure_subscription
from . import azure_vm
from . import aws_config
from . import aws_asset_ingest
from . import aws_inventory

__all__ = [
'aws_asset_ingest',
'aws_inventory',
'aws_cloudtrail',
'aws_config',
'azure_log',
Expand All @@ -17,7 +17,7 @@
]

connectors = {
'aws_asset_ingest': aws_asset_ingest,
'aws_inventory': aws_inventory,
'aws_cloudtrail': aws_cloudtrail,
'aws_config': aws_config,
'azure_log': azure_log,
Expand Down
2 changes: 1 addition & 1 deletion src/connectors/aws_cloudtrail.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""AWS CloudTrail
Collect AWS logs from an S3 bucket
Collects AWS logs from an S3 bucket using AssumeRole Grants
"""

from json import dumps
Expand Down
2 changes: 1 addition & 1 deletion src/connectors/aws_config.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""AWS Config
Collects Config logs from S3 into a columnar table
Collects Config logs from S3 using AssumeRole Grants
"""
from json import dumps
from time import sleep
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""AWS Asset Inventory
Collects AWS EC2, SG, ELB details into a columnar table
Collects AWS EC2, SG, ELB details using an Access Key
"""
from datetime import datetime
import json
Expand Down Expand Up @@ -102,7 +102,7 @@ def create_asset_table(connection_name, asset_type, columns, options):

comment = f'''
---
module: aws_asset_ingest
module: aws_inventory
aws_access_key: {aws_access_key}
aws_secret_key: {aws_secret_key}
'''
Expand Down
4 changes: 2 additions & 2 deletions src/connectors/azure_log.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""Azure Activity Logs
Collect Active Directory (AD) Sign-ins, Audit, or Operation Logs
"""Azure Active Directory Logs
Collect AD Signin, Audit, or Operation Logs using an SAS Token
"""

import re
Expand Down
2 changes: 1 addition & 1 deletion src/connectors/azure_subscription.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""Azure Subscription Inventory
Collect a list of accessible Azure subscriptions
Collects Azure Subscriptions using a Service Principal (SP)
"""

from dateutil.parser import parse
Expand Down
2 changes: 1 addition & 1 deletion src/connectors/azure_vm.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""Azure VM Inventory
Collect Azure VM inventory from Subscriptions
Collect Azure VM Inventory using an SP and Subscription Inventory
"""

from azure.common.credentials import ServicePrincipalCredentials
Expand Down
2 changes: 1 addition & 1 deletion src/connectors/okta.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""Okta System Log
Collect Okta activity logs
Collect Okta activity logs using an API Token
"""

from runners.helpers import db, log
Expand Down

0 comments on commit 6f739f0

Please sign in to comment.