Add snowpark entities #1959
Open
Add snowpark entities #1959
+522
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntities # Conflicts: # tests/streamlit/__snapshots__/test_commands.ambr # tests/test_data/projects/example_streamlit_v2/snowflake.yml
…tities_basic # Conflicts: # src/snowflake/cli/_plugins/streamlit/streamlit_entity.py
Closed
5 tasks
| if not FeatureFlag.ENABLE_NATIVE_APP_CHILDREN.is_enabled(): | ||
| raise NotImplementedError("Snowpark entity is not implemented yet") |
There was a problem hiding this comment.
What's the reasoning behind this flag?
There was a problem hiding this comment.
It was introduced in #1856
As we are not introducing entities in commands just yet, it seems reasonable to turn them off by default.
| allow_shared_libraries: bool = False, | ||
| *args, | ||
| **kwargs, | ||
| ): |
There was a problem hiding this comment.
Please add type hint
| def get_execute_sql(self, execution_arguments: List[str] | None = None): | ||
| raise NotImplementedError | ||
|
|
||
| def get_usage_grant_sql(self, app_role: str): |
There was a problem hiding this comment.
Suggested change
| def get_usage_grant_sql(self, app_role: str): | |
| def get_usage_grant_sql(self, role: str): |
There's nothing app specific in this query as far as I can tell
Comment on lines
197
to
207
| def get_describe_sql(self): | ||
| return f"DESCRIBE {self.model.type.upper()} {self.identifier}" | ||
|
|
||
| def get_drop_sql(self): | ||
| return f"DROP {self.model.type.upper()} {self.identifier}" | ||
|
|
||
| def get_execute_sql(self, execution_arguments: List[str] | None = None): | ||
| raise NotImplementedError | ||
|
|
||
| def get_usage_grant_sql(self, app_role: str): | ||
| return f"GRANT USAGE ON {self.model.type.upper()} {self.identifier} TO ROLE {app_role}" |
There was a problem hiding this comment.
Good candidates to extract to parent, generic class.
sfc-gh-jsikorski
force-pushed
the
jsikorski/snowpark_entities_basic
branch
from
762aa80 to
801b67d
Compare
| """ | ||
| # 0 Create a directory for the entity | ||
| if not output_dir: | ||
| output_dir = self.root / "output" / self.model.stage |
There was a problem hiding this comment.
Output dir should be "output/bundle/snowpark"
| return "\n".join(query) | ||
|
|
||
| def get_execute_sql(self, execution_arguments: List[str] | None = None): | ||
| raise NotImplementedError |
There was a problem hiding this comment.
Should this be not implemented?
sfc-gh-turbaszek
previously approved these changes
Jan 13, 2025
sfc-gh-jsikorski
force-pushed
the
jsikorski/snowpark_entities_basic
branch
from
e1deb64 to
9a34c4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Basic implementation of snowpark entities - to be updated after introducing bundle map for all entities.