Revert to unsorted Dataframe for Delta and Hudi #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #102 I changed how we partition and sort the DataFrame before writing to the Lake. The new partitioning is working well for all output formats. But the extra sort step is not strictly unnecessary for Delta and Hudi. This commit removes the sort step for Delta/Hudi only, to slightly improve cpu utilization.
istreeter
force-pushed
the
remove-redundant-sort
branch
from
e5d775c to
ddcf87c
Compare
|
Sharing a graph which demonstrates this has a measurable impact. The metric shown is The metric shows that the current PR improves the processing latency by a small but consistent amount.
There was also a slight measurable improvement in cpu utilization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #102 I changed how we partition and sort the DataFrame before writing to the Lake.
The new partitioning is working well for all output formats. But the extra sort step is not strictly unnecessary for Delta and Hudi. This commit removes the sort step for Delta/Hudi only, to slightly improve cpu utilization.