Add Base Macros #62
Merged
Add Base Macros #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowplowcla
added
the
cla:yes
georgewoodhead
force-pushed
the
feature/base-macros
branch
from
c29ec39 to
aa8d236
Compare
georgewoodhead
force-pushed
the
feature/base-macros
branch
2 times, most recently
from
3c0e407 to
e7518c4
Compare
rlh1994
approved these changes
Nov 22, 2023
models/media_ad_views/scratch/snowplow_media_player_media_ad_views_this_run.sql
Show resolved
Hide resolved
rlh1994
reviewed
Nov 22, 2023
georgewoodhead
force-pushed
the
feature/base-macros
branch
from
b2ed7ff to
7d7af57
Compare
matus-tomlein
approved these changes
Nov 27, 2023
georgewoodhead
force-pushed
the
feature/base-macros
branch
from
d28bcf9 to
82daa3c
Compare
georgewoodhead
merged commit bcd6e3a
into
release/snowplow-media-player/0.7.0
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Update the package to use the latest snowplow utils base macros. This enables you to specify your session and user identifiers used in the incremental building of the models.
Changes to the default session identifier
We’ve changed the default session identifier from being the
domain_sessionid, to now be the media session id (or page/screen view id if the media session entity is not set).Previously if a user paused some content and switched to another tab for an hour or so before coming back to finish watching the content, it could mean these subsequent media events would be disregarded. This was because the original domain_sessionid would have expired and the stray media events attached to the new domain_sessionid would be removed in the models deduplication steps (similar to the stray page pings). In this scenario the media session id and page_view_id remain the same enabling us to model the complete media play.
We have added a new field to the base and ad views tables,
domain_sessionid_array, which shows all thedomain_sessionidvalues attached to a media play, thus keeping the ability to perform session level analysis.We have also added the option to passthrough fields to the base and ad views models.
Checklist