Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embedFileRelative function. #48

Merged
merged 4 commits into from
Jan 28, 2024

Conversation

my-name-is-lad
Copy link
Contributor

This PR adds a handful shortcut to embed files with path relative to project root. That's it.

Copy link
Owner

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a minor version bump, changelog entry, and @since comment on the new function?

@my-name-is-lad
Copy link
Contributor Author

Done.

ChangeLog.md Outdated
@@ -1,5 +1,9 @@
# ChangeLog for file-embed

## 0.0.15.1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor version bump would bring this to 0.0.16, necessary by the PVP since this adds a new identifier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@snoyberg snoyberg merged commit ec0b53c into snoyberg:master Jan 28, 2024
@snoyberg
Copy link
Owner

New release is now on Hackage. Thanks!

@my-name-is-lad my-name-is-lad deleted the embed-file-relative branch January 30, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants