Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that -fno-full-laziness may be needed #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

unhammer
Copy link

@unhammer unhammer commented May 16, 2019

This took way too long to find out – could be useful to others who are not able to guess that it would be needed :)

(Though I'm not sure if it's best to have it in README or at the top of Text.XML.Stream.Parse's haddocks?)

@k0ral
Copy link
Collaborator

k0ral commented May 17, 2019

Please correct me if I am wrong, but after reading the article from FP Complete and this comment, the issue does not seem to be specific to xml-conduit, but to any library that uses conduit (or any streaming library in general).
Therefore, I would rather move the -fno-full-laziness suggestion to conduit's README, rather than repeating it in each and every conduit-based library.
What do you think ?

@unhammer
Copy link
Author

unhammer commented May 17, 2019

Where is it most discoverable in practice for people who run into memory issues? The reason I added a PR to xml-conduit was that I was sure it happens there with trivial examples but not sure it happened elsewhere with such trivial examples; but that last comment does seem to suggest it goes for anything depending on conduit >=1.3.

And then to complicate matters, it seems like people have had issues not just with streaming libraries but full laziness in general

@mniip mniip mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants