feat: error transfer between typescript and golang #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cliv2/cmd/cliv2/main.go
Outdated
| @@ -29,6 +27,7 @@ import ( | |||
| "github.com/snyk/go-application-framework/pkg/instrumentation" | |||
| "github.com/snyk/go-application-framework/pkg/local_workflows/network_utils" | |||
| "github.com/snyk/go-application-framework/pkg/local_workflows/output_workflow" | |||
| _ "github.com/snyk/go-application-framework/pkg/networking/fips_enable" | |||
There was a problem hiding this comment.
Issue: please move this to be the first import ;)
| return err | ||
| } | ||
|
|
||
| data, fileErr := os.ReadFile(filePath) |
There was a problem hiding this comment.
Suggestion: I'm contemplating if we should be more tolerant and allow the file to be optional? Because otherwise we might fail to run to the end and show the actual issue.
There was a problem hiding this comment.
Also I guess you might be able to move this logic to its own function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Iterating on the work from #5626, this adds the possibility of sending errors originating from the TypeScript CLI to our Golang CLI. The errors are wrapped in our generic Error Catalog model before being serialized as JSON API errors and written in the temporary error file used as a mean for IPC.
Where should the reviewer start?
How should this be manually tested?
Related
CLI-646