Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test, monitor): fix OutOfSync errors in pnpm for download urls #5694

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

gemaxim
Copy link
Contributor

@gemaxim gemaxim commented Jan 29, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

Bumps nodejs-lockfile-parser and snyk-nodejs-plugin with a fix in pnpm for handling download urls from codelab for example, in package.json files.
Changes in this PR: snyk/nodejs-lockfile-parser#260.

Where should the reviewer start?

Tests in the lockfile parser are included in the above PR for all lockfile versions.
Updated acceptance test for pnpm in this cli PR.

How should this be manually tested?

Create a project with files included in the fixtures ( example ). Run snyk test or snyk monitor succesfully.

@gemaxim gemaxim requested a review from a team as a code owner January 29, 2025 07:25
@gemaxim gemaxim self-assigned this Jan 29, 2025
@gemaxim gemaxim force-pushed the fix/OSM-2314/handle-codelab-references-pnpm branch from edbbad0 to db0bfd2 Compare January 29, 2025 07:36
@sandor-trombitas sandor-trombitas force-pushed the fix/OSM-2314/handle-codelab-references-pnpm branch from db0bfd2 to 62912e2 Compare January 29, 2025 08:38
@sandor-trombitas sandor-trombitas force-pushed the fix/OSM-2314/handle-codelab-references-pnpm branch from 62912e2 to b6e4ea0 Compare January 29, 2025 08:39
@sandor-trombitas sandor-trombitas merged commit d99e102 into main Jan 29, 2025
7 checks passed
@sandor-trombitas sandor-trombitas deleted the fix/OSM-2314/handle-codelab-references-pnpm branch January 29, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants