Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handling large certificate bundle #5695

Closed

Conversation

thisislawatts
Copy link
Member

@thisislawatts thisislawatts commented Jan 29, 2025

  • test: capture oversized certificate bundle scenario
  • test: drop out stdout
  • chore(deps): switch to stripe/goproxy
  • test: isolate tests from global config store
  • test: fix missing server listen

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

CLI-658

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Warnings
⚠️ There are multiple commits on your branch, please squash them locally before merging!

Generated by 🚫 dangerJS against 2799ce2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should pull this in dynamically, this is inlined version from:
https://curl.se/docs/caextract.html

@thisislawatts thisislawatts force-pushed the fix/large-certificate-bundle-with-stripe-goproxy branch from 76a6ad6 to 2799ce2 Compare January 29, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant