Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect issue cache state [HEAD-972] #393

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

PeterSchafer
Copy link
Contributor

@PeterSchafer PeterSchafer commented Oct 31, 2023

Description

In certain constellations, the displayed number of issues varied over time even if the existing issues didn't change. There was a bug in a library used for caching issues, which triggered this bug. The PR updates the library in the affected use case.

Since this is a timing issue, it is difficult to provide a test to prove the fix.

Checklist

  • Tests added and all succeed
  • Linted
  • README.md updated, if user-facing
  • License file updated, if new 3rd-party dependency is introduced

Screenshots / GIFs

@PeterSchafer PeterSchafer temporarily deployed to Standard October 31, 2023 17:28 — with GitHub Actions Inactive
@PeterSchafer PeterSchafer temporarily deployed to MT1 October 31, 2023 17:28 — with GitHub Actions Inactive
@PeterSchafer PeterSchafer temporarily deployed to MT3 October 31, 2023 17:28 — with GitHub Actions Inactive
@PeterSchafer PeterSchafer temporarily deployed to Standard November 2, 2023 12:20 — with GitHub Actions Inactive
@PeterSchafer PeterSchafer temporarily deployed to MT1 November 2, 2023 12:20 — with GitHub Actions Inactive
@PeterSchafer PeterSchafer temporarily deployed to MT3 November 2, 2023 12:20 — with GitHub Actions Inactive
@Team-Hammerhead Team-Hammerhead temporarily deployed to Standard November 2, 2023 12:24 — with GitHub Actions Inactive
@Team-Hammerhead Team-Hammerhead temporarily deployed to MT1 November 2, 2023 12:24 — with GitHub Actions Inactive
@Team-Hammerhead Team-Hammerhead temporarily deployed to MT3 November 2, 2023 12:24 — with GitHub Actions Inactive
@PeterSchafer PeterSchafer marked this pull request as ready for review November 2, 2023 13:25
@PeterSchafer PeterSchafer requested a review from a team as a code owner November 2, 2023 13:25
@bastiandoetsch
Copy link
Collaborator

Commit signing needs a squash :)

WIP

fix: upgrade dependency

Revert "fix: incorrect issue cache state"

This reverts commit 6c4b8c8.

docs: updated licenses
@PeterSchafer PeterSchafer force-pushed the fix/HEAD-972_issue_caching branch from 18590e0 to 3343efb Compare November 2, 2023 13:31
@PeterSchafer PeterSchafer temporarily deployed to Standard November 2, 2023 13:32 — with GitHub Actions Inactive
@PeterSchafer PeterSchafer temporarily deployed to MT1 November 2, 2023 13:32 — with GitHub Actions Inactive
@PeterSchafer PeterSchafer temporarily deployed to MT3 November 2, 2023 13:32 — with GitHub Actions Inactive
@PeterSchafer PeterSchafer changed the title fix: incorrect issue cache state fix: incorrect issue cache state [HEAD-972] Nov 2, 2023
@PeterSchafer PeterSchafer merged commit a925469 into main Nov 2, 2023
10 checks passed
@PeterSchafer PeterSchafer deleted the fix/HEAD-972_issue_caching branch November 2, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants