Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: possible lsp disconnects on proxy errors #409

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

PeterSchafer
Copy link
Contributor

Description

Fix disconnects of LSP client and server in case of proxy connection issues, caused by error messages written to stdout.

Checklist

  • Tests added and all succeed
  • Linted
  • README.md updated, if user-facing
  • License file updated, if new 3rd-party dependency is introduced

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

through upgrade of GAF which upgrades go-httpauth which doesn’t print to stdout anymore.
@PeterSchafer PeterSchafer merged commit 498c98c into main Nov 20, 2023
10 checks passed
@PeterSchafer PeterSchafer deleted the fix/HEAD-1041_disconnect_on_proxy_err branch November 20, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants