feat: Sending IDE+extension versions to autofix #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
antoine-snyk
force-pushed
the
feat/autofix/ide_extension_details
branch
from
611a654 to
cec7b3f
Compare
antoine-snyk
force-pushed
the
feat/autofix/ide_extension_details
branch
from
cec7b3f to
85c5c26
Compare
|
Would you please add tests? |
antoine-snyk
force-pushed
the
feat/autofix/ide_extension_details
branch
from
85c5c26 to
d2c0dd8
Compare
antoine-snyk
force-pushed
the
feat/autofix/ide_extension_details
branch
from
d2c0dd8 to
8b09963
Compare
antoine-snyk
force-pushed
the
feat/autofix/ide_extension_details
branch
from
8b09963 to
11787ff
Compare
antoine-snyk
force-pushed
the
feat/autofix/ide_extension_details
branch
from
11787ff to
d6994a2
Compare
|
Sure. I am adding a test for composing the request to autofix. I also replaced the map with a proper struct for the feedback. |
bastiandoetsch
approved these changes
Jan 10, 2025
antoine-snyk
force-pushed
the
feat/autofix/ide_extension_details
branch
from
d6994a2 to
5d52e2a
Compare
This is for analytics purposes as different IDEs extensions might support different features at a certain point in time. feat: Adding test to autofixRequestBody
antoine-snyk
force-pushed
the
feat/autofix/ide_extension_details
branch
from
5d52e2a to
fb74b26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is sending the IDE name and version and the extension name and version to autofix requests and feedback events.
This is for analytics purposes. IDE extensions might support different features at a given point in time and knowing the extension used helps knowing what features are available to the end user.
Checklist