Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont resolve venv symlinks #747

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix: dont resolve venv symlinks #747

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f183e3
fix: dont resolve venv symlinks
ShawkyZ Jan 8, 2025
224fe45
fix: dont set PYTHONPATH and PYTHONHOME
ShawkyZ Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions internal/sdk/sdk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,10 @@ func UpdateEnvironmentAndReturnAdditionalParams(sdks []types.LsSdk, logger zerol
case strings.Contains(strings.ToLower(sdk.Type), "java"):
env["JAVA_HOME"] = path
case strings.Contains(strings.ToLower(sdk.Type), "python"):
symlinks, err := filepath.EvalSymlinks(path)
if err != nil {
symlinks = path
}
env["PYTHONPATH"] = symlinks
env["PYTHONHOME"] = filepath.Dir(symlinks)
pathExt = filepath.Dir(symlinks)
additionalParameters = append(additionalParameters, "--command="+symlinks)
env["PYTHONPATH"] = path
env["PYTHONHOME"] = filepath.Dir(path)
pathExt = filepath.Dir(path)
additionalParameters = append(additionalParameters, "--command="+path)
case strings.Contains(strings.ToLower(sdk.Type), "go"):
env["GOROOT"] = path
}
Expand Down
Loading