[READY] - init devServer gitlab runner #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will opt for leveraging kvm for the devServer going forward
sarcasticadmin
force-pushed
the
rh/devserver-runners
branch
from
b07e156
to
5d1e3ad
Compare
sarcasticadmin
requested review from
kylerisse,
ruebenramirez,
owendelong and
djacu
sarcasticadmin
force-pushed
the
rh/devserver-runners
branch
from
5d1e3ad
to
4e4dfdb
Compare
| @@ -11,7 +11,8 @@ | |||
| ## Table of Contents | |||
|
|
|||
| - [CONTRIBUTING](./CONTRIBUTING.md) | |||
| - [CI](./CI.md) | |||
| - [GitHub Actions CI](./CI.md) | |||
There was a problem hiding this comment.
nit: should we rename CI.md to github-actions-ci.md?
There was a problem hiding this comment.
I have a branch that moves all of these markdown files underneath docs/(since right now there spread all over). Id rather clean that up there if thats ok since well be moving it anyway.
ruebenramirez
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
I asked a few questions as comments, but LGTM. I see you have a working test executed here: https://gitlab.com/socallinuxexpo/scale-network/-/pipelines/1532846314
Nice work!
|
@ruebenramirez thanks for the review and good discussion 🙂 |
sarcasticadmin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Putting the devServer to work and adding a hosted gitlab-runner. Currently trigger on the
nixtag.This will allow us to run
nix flake check(includes vm tests)Had to bump to nixos-24.05 since we were pretty behind (~2023) for our flake input
nixpkgs. Will probably move to unstable after getting more time to test.Previous Behavior
devServerNew Behavior
devServerTests
nix flake checkpasses for this branch to ensure out vmTests work with new nixpkgs