Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Fix Search Posts bugs #596

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Frontend] Fix Search Posts bugs #596

wants to merge 4 commits into from

Conversation

badukwei
Copy link
Collaborator

@badukwei badukwei commented Dec 18, 2024

Summary

解決 Search 的時候 Enter 會自動 focus 到 Create Post Area 的問題,以及在其他頁面的 routing 錯誤問題。

Details

  1. Search 的時候 Enter 會自動 focus 到 Create Post Area 的問題
    所以我添加了一個 checker 讓如果沒有 value 的話,就不會執行下面程式。
editor.dispatchCommand(CLEAR_EDITOR_COMMAND, undefined)
editor.focus()
  1. 頁面的 routing 錯誤問題
    新增 exact route for search navigation

@badukwei badukwei requested review from Xiawpohr and ryanycw December 18, 2024 17:41
@github-actions github-actions bot added bug Something isn't working frontend and removed bug Something isn't working labels Dec 18, 2024
@github-actions github-actions bot added the bug Something isn't working label Dec 19, 2024
@ryanycw
Copy link
Member

ryanycw commented Dec 19, 2024

I think the second issue is indeed resolved. I am not so sure about the solution for the first issue. The current way to resolve the issue seems unstraightforward. Would love to ask @Xiawpohr to comment on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants