Merge pull request #52 from socialappslab/develop

fix: Update Dockerfile
socialappslab · Nov 4, 2024 · 9635793 · 9635793
2 parents 10ac0cc + c081bf2
commit 9635793
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/build-production.yml b/.github/workflows/build-production.yml
@@ -33,7 +33,7 @@ jobs:
           ECR_REPOSITORY: ${{ secrets.REPO_NAME_PROD }}
           IMAGE_TAG: ${{ steps.package-version.outputs.version }}
         run: |
-          docker build -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG .
+          docker build --build-arg ENV_NAME=production -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG .
           docker tag $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG $ECR_REGISTRY/$ECR_REPOSITORY:latest
           docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
           docker push $ECR_REGISTRY/$ECR_REPOSITORY:latest
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -33,7 +33,7 @@ jobs:
           ECR_REPOSITORY: ${{ secrets.REPO_NAME }}
           IMAGE_TAG: ${{ steps.get-commit-hash.outputs.commit-hash }}
         run: |
-          docker build -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG .
+          docker build --build-arg ENV_NAME=develop -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG .
           docker tag $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG $ECR_REGISTRY/$ECR_REPOSITORY:latest
           docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
           docker push $ECR_REGISTRY/$ECR_REPOSITORY:latest
diff --git a/Dockerfile b/Dockerfile
@@ -7,7 +7,7 @@ COPY package.json ./
 RUN yarn install --frozen-lockfile
 
 # Copy the rest of the application code
-ARG ENV_NAME="develop"
+ARG ENV_NAME
 COPY . .
 RUN if [ "$ENV_NAME" = "production" ]; then rm .env.development && mv .env.production .env ; fi
 RUN if [ "$ENV_NAME" = "develop" ]; then rm .env.production && mv .env.development .env && echo "arg: "$ENV_NAME ; fi