Always show the last console output before abort #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v9.x.x #53 +/- ##
=========================================
+ Coverage 1.53% 1.53% +<.01%
=========================================
Files 20 20
Lines 588 587 -1
=========================================
Hits 9 9
+ Misses 579 578 -1 |
nemanja-boric-sociomantic
approved these changes
Jul 20, 2018
|
Ping. |
mihails-strasuns
requested review from
mihails-strasuns
and removed request for
mihails-strasuns-sociomantic
|
Sorry for missing this. What problem exactly is this trying to solve? With code as proposed, last console output will be printed twice when verbose trace is enabled. |
Ah yes, that is true. I hadn't thought of that case. The reason I was interested in the final console output was because the verbose trace wasn't working for me. I have raised a separate issue #56 for addressing that problem. Fixing that would make this PR pointless, so I'll close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're going to abort anyway, why not just always show the last console output.