Closing the body after hijack

socketry · Apr 5, 2024 · 73c6b38 · 73c6b38
1 parent 418ca04
commit 73c6b38
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/async/http/protocol/http1/server.rb b/lib/async/http/protocol/http1/server.rb
@@ -50,7 +50,10 @@ def each(task: Task.current)
 							response = yield(request, self)
 							body = response&.body
 
-							return if hijacked?
+							if hijacked?
+								body&.close
+								return
+							end
 
 							task.defer_stop do
 								# If a response was generated, send it:

diff --git a/test/async/http/protocol/http11.rb b/test/async/http/protocol/http11.rb
@@ -103,7 +103,7 @@ def around
 			end
 
 			it "works properly" do
-				expect(body).not.to receive(:close)
+				expect(body).to receive(:close)
 
 				response = client.get("/")