Ignore non-final responses. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
ignore-informational-response
branch
from
7d2dea1 to
f868ac4
Compare
|
|
||
| # @parameter reason [String] HTTP response line reason phrase | ||
| # @parameter reason [String] HTTP response line reason phrase. | ||
| def initialize(connection, version, status, reason, headers, body) |
There was a problem hiding this comment.
Looks here like the docs for the initialize args aren't fully here, or perhaps I am missing something that ain't visible right here in the commit diff.
There was a problem hiding this comment.
You are right, the documentation could do with some improvement I suppose.
|
The HTTP/2 headers processing could probably be better, but it seems to pass all tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While informational responses are not particularly popular, we should at least ignore them. Later, we may expose them to the user.
Types of Changes
Contribution