Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ss-jade accept locals from serveClient #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lge88
Copy link

@lge88 lge88 commented Jan 19, 2013

This make ss-jade accept parameter from res.serveClient(). It depends on the pull:
socketstream/socketstream#341

res.serveClient('main', {
  title : 'main',
  version : '1.0'
});

@paulbjensen
Copy link

Hi,

Thanks for this feature addition. I like it, but I'd like to add a way to pass the options so that they are namespaced. I may adjust it so that it looks like this:

res.serveClient('main', {
jade: {
locals: {
title : 'main',
version : '1.0'
}
}
});

The reason for wanting to do this is in case we add a feature that allows passing options to serveClient which are not to do with jade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants