Skip to content

Commit

Permalink
refactor(src/cli/cli.cc): drop unused additional flags
Browse files Browse the repository at this point in the history
  • Loading branch information
chicoxyzzy committed Nov 3, 2023
1 parent 9d24e8d commit e476632
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions src/cli/cli.cc
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,6 @@ void handleBuildPhaseForUserScript (
const String& targetPlatform,
const Path pathResourcesRelativeToUserBuild,
const Path& cwd,
const String& additionalArgs,
bool performAfterLifeCycle
) {
do {
Expand All @@ -512,7 +511,6 @@ void handleBuildPhaseForUserScript (

if (shouldPassBuildArgs) {
buildArgs << " " << pathResourcesRelativeToUserBuild.string();
buildArgs << " " << additionalArgs;
}

if (settings.contains("build_script") && settings.at("build_script").size() > 0) {
Expand Down Expand Up @@ -2625,7 +2623,6 @@ int main (const int argc, const char* argv[]) {

String argvForward = "";
String targetPlatform = optionsWithValue["--platform"];
String additionalBuildArgs = "";

bool flagRunUserBuildOnly = optionsWithoutValue.find("--only-build") != optionsWithoutValue.end() || equal(rc["build_only"], "true");
bool flagCodeSign = optionsWithoutValue.find("--codesign") != optionsWithoutValue.end() || equal(rc["build_codesign"], "true");
Expand Down Expand Up @@ -2815,16 +2812,6 @@ int main (const int argc, const char* argv[]) {

auto pathResourcesRelativeToUserBuild = paths.pathResourcesRelativeToUserBuild;

const bool shouldPassBuildArgs = settings.contains("build_pass.build.arguments") && settings.at("build_pass.build.arguments") == "true";

if (flagDebugMode && shouldPassBuildArgs) {
additionalBuildArgs += " --debug=true";
}

if (flagBuildTest && shouldPassBuildArgs) {
additionalBuildArgs += " --test=true";
}

String flags;
String files;

Expand Down Expand Up @@ -4518,7 +4505,6 @@ int main (const int argc, const char* argv[]) {
targetPlatform,
pathResourcesRelativeToUserBuild,
oldCwd,
additionalBuildArgs,
true
);

Expand Down Expand Up @@ -6330,7 +6316,6 @@ int main (const int argc, const char* argv[]) {
targetPlatform,
pathResourcesRelativeToUserBuild,
targetPath,
additionalBuildArgs,
false
);

Expand Down

0 comments on commit e476632

Please sign in to comment.