Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api/notifications): fix 'Notification.requestPermission' #750

Merged
merged 1 commit into from
Nov 3, 2023
Merged

refactor(api/notifications): fix 'Notification.requestPermission' #750

merged 1 commit into from
Nov 3, 2023

Conversation

jwerle
Copy link
Member

@jwerle jwerle commented Nov 3, 2023

No description provided.

@jwerle jwerle added javascript An issue, discussion, or task related to the runtime javascript api An issue, task, or discussion related to public runtime APIs labels Nov 3, 2023
@jwerle jwerle requested review from bcomnes and chicoxyzzy November 3, 2023 22:51
@jwerle jwerle self-assigned this Nov 3, 2023
@jwerle jwerle merged commit e9e5ab4 into master Nov 3, 2023
2 of 8 checks passed
@jwerle jwerle deleted the fix-notification-request-permission branch November 3, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcomnes bcomnes bcomnes approved these changes

@chicoxyzzy chicoxyzzy Awaiting requested review from chicoxyzzy

Assignees

@jwerle jwerle

Labels
api An issue, task, or discussion related to public runtime APIs javascript An issue, discussion, or task related to the runtime javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwerle @bcomnes