Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parenthesis to check filter #2033

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add parentheses to passing_sql filter as well
abargar committed Mar 11, 2024
commit 0e13c02f093ec60b0d810b3aa459f24a2a5b4f35
2 changes: 1 addition & 1 deletion soda/core/soda/execution/metric/numeric_query_metric.py
Original file line number Diff line number Diff line change
@@ -324,7 +324,7 @@ def create_failed_rows_sample_query(self) -> SampleQuery | None:

if self.filter:
where_clauses.append(f"({self.filter})")
passing_where_clauses.append(self.filter)
passing_where_clauses.append(f"({self.filter})")

where_sql = " AND ".join(where_clauses)
passing_where_sql = " AND ".join(passing_where_clauses)