Add the build and test script for ARM64 #1133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add docker.arm64 in Makefile, use make docker.arm64 to build images for arm. - Add opensds-all-arm-dev.yaml to test opensds with noauth Signed-off-by: wangzihao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## development #1133 +/- ##
============================================
Coverage 34.88% 34.88%
============================================
Files 97 97
Lines 17583 17583
============================================
Hits 6133 6133
Misses 10580 10580
Partials 870 870 |
wisererik
reviewed
Dec 18, 2019
| type: Directory | ||
| --- | ||
| ################################################################################################## | ||
| # Authchecker service |
There was a problem hiding this comment.
remove unused code here
| --- | ||
| ################################################################################################## | ||
| # Dashboard service | ||
| ################################################################################################## |
Makefile
Outdated
| cp $(BUILD_DIR)/bin/osdsdock ./cmd/osdsdock | ||
| cp $(BUILD_DIR)/bin/osdslet ./cmd/osdslet | ||
| cp $(BUILD_DIR)/bin/osdsapiserver ./cmd/osdsapiserver | ||
| docker build cmd/osdsdock -t opensdsio/opensds-dock-arm64:ci |
There was a problem hiding this comment.
Hi @wisererik . I used ci tag to test on my machine ,and sorry for that . I have update it to latest. Please take a look, thanks!
go.mod
Outdated
| @@ -46,7 +46,6 @@ require ( | |||
| go.uber.org/zap v1.12.0 // indirect | |||
| golang.org/x/crypto v0.0.0-20190510104115-cbcb75029529 | |||
| golang.org/x/time v0.0.0-20191024005414-555d28b269f0 // indirect | |||
| google.golang.org/appengine v1.4.0 // indirect | |||
| google.golang.org/grpc v1.24.0 | |||
There was a problem hiding this comment.
please don't go.mod if there is no change of go code.
- remove unused code - change the tag of arm images - restore go.mod Signed-off-by: wangzihao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for arm.
Signed-off-by: wangzihao [email protected]
What this PR does / why we need it:
This PR add the support for building opensds on ARM64. There are some ARM servers like huawei cloud is used to storage. Opensds may need to run on ARM.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #fixes #1130
Special notes for your reviewer:
Release note: