perf: improve assign ops/s by 2x

sodiray · Apr 5, 2024 · 8fa0e2b · 8fa0e2b
1 parent 069b26c
commit 8fa0e2b
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 40 deletions.
diff --git a/cdn/radash.esm.js b/cdn/radash.esm.js
@@ -748,19 +748,17 @@ const set = (initial, path, value) => {
 const assign = (initial, override) => {
   if (!initial || !override)
     return initial ?? override ?? {};
-  return Object.entries({ ...initial, ...override }).reduce(
-    (acc, [key, value]) => {
-      return {
-        ...acc,
-        [key]: (() => {
-          if (isObject(initial[key]))
-            return assign(initial[key], value);
-          return value;
-        })()
-      };
-    },
-    {}
-  );
+  const merged = { ...initial };
+  for (const key in override) {
+    if (override.hasOwnProperty(key)) {
+      if (isObject(initial[key])) {
+        merged[key] = assign(initial[key], override[key]);
+      } else {
+        merged[key] = override[key];
+      }
+    }
+  }
+  return merged;
 };
 const keys = (value) => {
   if (!value)

diff --git a/cdn/radash.js b/cdn/radash.js
@@ -751,19 +751,17 @@ var radash = (function (exports) {
   const assign = (initial, override) => {
     if (!initial || !override)
       return initial ?? override ?? {};
-    return Object.entries({ ...initial, ...override }).reduce(
-      (acc, [key, value]) => {
-        return {
-          ...acc,
-          [key]: (() => {
-            if (isObject(initial[key]))
-              return assign(initial[key], value);
-            return value;
-          })()
-        };
-      },
-      {}
-    );
+    const merged = { ...initial };
+    for (const key in override) {
+      if (override.hasOwnProperty(key)) {
+        if (isObject(initial[key])) {
+          merged[key] = assign(initial[key], override[key]);
+        } else {
+          merged[key] = override[key];
+        }
+      }
+    }
+    return merged;
   };
   const keys = (value) => {
     if (!value)

diff --git a/cdn/radash.min.js b/cdn/radash.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "radash",
-  "version": "12.1.0",
+  "version": "12.1.1",
   "description": "Functional utility library - modern, simple, typed, powerful",
   "main": "dist/cjs/index.cjs",
   "module": "dist/esm/index.mjs",

diff --git a/src/object.ts b/src/object.ts
@@ -275,19 +275,20 @@ export const assign = <X extends Record<string | symbol | number, any>>(
 ): X => {
   if (!initial || !override) return initial ?? override ?? {}
 
-  return Object.entries({ ...initial, ...override }).reduce(
-    (acc, [key, value]) => {
-      return {
-        ...acc,
-        [key]: (() => {
-          if (isObject(initial[key])) return assign(initial[key], value)
-          // if (isArray(value)) return value.map(x => assign)
-          return value
-        })()
+  const merged = { ...initial }
+
+  for (const key in override) {
+    if(override.hasOwnProperty(key)) {
+      if(isObject(initial[key])) {
+        merged[key] = assign(initial[key], override[key])
       }
-    },
-    {} as X
-  )
+      else {
+        merged[key] = override[key]
+      }
+    }
+  }
+
+  return merged;
 }
 
 /**