-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set compilation of plugins by default #141
Merged
fredroy
merged 4 commits into
sofa-framework:master
from
bakpaul:24_12_enable_default_compilation_of_GUI
Feb 12, 2025
Merged
Set compilation of plugins by default #141
fredroy
merged 4 commits into
sofa-framework:master
from
bakpaul:24_12_enable_default_compilation_of_GUI
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI must be updated accordingly
alxbilger
approved these changes
Feb 5, 2025
fredroy
approved these changes
Feb 12, 2025
hugtalbot
pushed a commit
to hugtalbot/SofaGLFW
that referenced
this pull request
Feb 12, 2025
* Set compilation by default * Update ci.yml * Update ci.yml
fredroy
added a commit
that referenced
this pull request
Feb 13, 2025
* Fix compilation with Lifecycle v25.06 * Fix compilation further to lifecycle v25.06 * Remove un-needed CXX flag * Set compilation of plugins by default (#141) * Set compilation by default * Update ci.yml * Update ci.yml * Set priotity to force Imgui as the default GUI (#149) * remove changes unrelated to the PR * Apply suggestions from code review --------- Co-authored-by: Paul Baksic <[email protected]> Co-authored-by: Frederick Roy <[email protected]>
EulalieCoevoet
pushed a commit
to SofaComplianceRobotics/SofaGLFW
that referenced
this pull request
Feb 18, 2025
* Set compilation by default * Update ci.yml * Update ci.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at making SofaImGUI as the GUI by default
See sofa-framework/sofa#5176