Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load the first time you use hessian serialization #339

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Load the first time you use hessian serialization #339

merged 3 commits into from
Feb 20, 2024

Conversation

funky-eyes
Copy link
Contributor

fixes #338

@sofastack-cla sofastack-cla
Copy link

sofastack-cla bot commented Feb 2, 2024

Hi @funky-eyes, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

OrezzerO
OrezzerO approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OrezzerO
Copy link
Collaborator

OrezzerO commented Feb 5, 2024

Hi, @funky-eyes , please run mvn clean compile -DskipTests in your local, it will reformat your code, and then commit your code.

@funky-eyes
Copy link
Contributor Author

Hi, @funky-eyes , please run mvn clean compile -DskipTests in your local, it will reformat your code, and then commit your code.

Okay, hold on, please.

@sofastack-cla sofastack-cla bot added cla:yes and removed cla:no labels Feb 5, 2024
@funky-eyes
Copy link
Contributor Author

Hi, @funky-eyes , please run mvn clean compile -DskipTests in your local, it will reformat your code, and then commit your code.

done

chuailiwu
chuailiwu approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@chuailiwu chuailiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chuailiwu chuailiwu merged commit 6b127c1 into sofastack:master Feb 20, 2024
1 check passed
JoeCqupt pushed a commit to JoeCqupt/sofa-bolt that referenced this pull request Jun 5, 2024
@funky-eyes
Load the first time you use hessian serialization (sofastack#339)
e2feb8e 
* Load the first time you use hessian serialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuailiwu chuailiwu chuailiwu approved these changes

@OrezzerO OrezzerO OrezzerO approved these changes

Assignees
No one assigned
Labels
cla:yes First-time contributor size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hessian dependency conflict
3 participants
@funky-eyes @OrezzerO @chuailiwu