refactor sesion data store module #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. remove WriteDataProcessor: avoid creating unnecessary objects 2. standardize the use of generic types to avoid code warnings
1. remove WriteDataProcessor: avoid creating unnecessary objects 2. standardize the use of generic types to avoid code warnings
|
本次pr修改的类文件比较多，其中session上的存储结构的修改也比较大，是否可以在issue补充一些修改后的存储结构的设计考量，对象关系图等。这样对cr人会比较友好。 |
|
基础存储接口和实现如上图，他们和具体业务无关：
|
|
nocvalight
reviewed
May 25, 2023
| @Override | ||
| public Pair<Boolean, T> putIfAbsent(T storeData) { | ||
| String dataInfoId = storeData.getDataInfoId(); | ||
| ClientsGroup<T> clientsGroup = groups.get(dataInfoId); |
There was a problem hiding this comment.
这里可以直接使用computeIfAbsent()？不用自己做两次 == null的判断。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: