Skip to content

Commit

Permalink
enhance log format (#1436)
Browse files Browse the repository at this point in the history
Co-authored-by: liujianjun.ljj <[email protected]>
  • Loading branch information
EvenLjj and liujianjun.ljj authored Aug 16, 2024
1 parent 46d1dcd commit b140ee6
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions core/api/src/main/java/com/alipay/sofa/rpc/log/LogCodes.java
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ public static String getLog(String code) {
return CODE_DOES_NOT_EXIST + code;
}
try {
return String.format(LOG, code, LOG_CODES.get(code), LogCodes.NOTE);
return format(code, LOG_CODES.get(code), LogCodes.NOTE);
} catch (Throwable e) {
LOGGER.error(LOG_FORMAT_ERROR + code, e);
}
Expand Down Expand Up @@ -428,7 +428,7 @@ public static String getLog(String code, Object... messages) {
}

try {
return String.format(LOG, code, MessageFormat.format(message, messages), LogCodes.NOTE);
return format(code, MessageFormat.format(message, messages), LogCodes.NOTE);
} catch (Throwable e) {
LOGGER.error(LOG_FORMAT_ERROR + code, e);
}
Expand Down Expand Up @@ -456,4 +456,9 @@ public static String getLiteLog(String codeOrMsg, Object... messages) {
}
return LITE_LOG_FORMAT_ERROR + codeOrMsg;
}

private static String format(String code, String message, String note) {
return "RPC-" + code + ": " + message + " " + note;
}

}

0 comments on commit b140ee6

Please sign in to comment.