Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Module reuse base data source #370

Merged
merged 18 commits into from
Dec 11, 2023
Merged

Module reuse base data source #370

merged 18 commits into from
Dec 11, 2023

Conversation

yuanyuancin
Copy link
Collaborator

No description provided.

@yuanyuancin yuanyuancin linked an issue Dec 5, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (ec783fe) 81.31% compared to head (bcdb232) 80.78%.

❗ Current head bcdb232 differs from pull request most recent head f660a68. Consider uploading reports for the commit f660a68 to get more accurate results

Files Patch % Lines
...serverless/common/service/ServiceProxyFactory.java 56.00% 7 Missing and 4 partials ⚠️
...y/sofa/serverless/common/api/SpringBeanFinder.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #370      +/-   ##
============================================
- Coverage     81.31%   80.78%   -0.53%     
+ Complexity       66       65       -1     
============================================
  Files            40       41       +1     
  Lines          1006     1015       +9     
  Branches         90       90              
============================================
+ Hits            818      820       +2     
- Misses          137      143       +6     
- Partials         51       52       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lvjing2
Copy link
Collaborator

lvjing2 commented Dec 7, 2023

Copy link
Collaborator

@lvjing2 lvjing2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuanyuancin yuanyuancin merged commit 8c48aeb into master Dec 11, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

增加 mysql samples, 模块复用基座数据源
3 participants