This repository has been archived by the owner on Aug 24, 2019. It is now read-only.
Small improvements #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2
commented
Oct 21, 2014
a2
commented
- Update result dictionary keys
- Don't delete keychain items when saving; update if possible
SecItemDelete is available starting on OS X 10.6; surely that's fine.
Previously, the existing keychain item was always deleted and then re-created.
| status = SecKeychainItemDelete((SecKeychainItemRef)result); | ||
| CFRelease(result); | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Ah, I didn't see that. I'll revert the commit.
This reverts commit 2aa9400.
|
Considered adding a commit updating the code to use keyed subscripting. Would that be useful or unnecessary? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.