Enforce the repair timeout when collecting repairs. #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, it didn't occur to me that collecting repairs can take a very, very long time: it's possible for this to take so long that it exceeds any reasonable memory limit. Foolishly, I *had* realised that `rank_rprs` needed a timeout, but I hadn't applied that to `collect_repairs`. This commit does that, ensuring that the user's input is less likely to cause grmtools to consume too much memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, it didn't occur to me that collecting repairs can take a very, very long time: it's possible for this to take so long that it exceeds any reasonable memory limit. Foolishly, I had realised that
rank_rprsneeded a timeout, but I hadn't applied that tocollect_repairs. This commit does that, ensuring that the user's input is less likely to cause grmtools to consume too much memory.Fixes #481.