[chore] Redis Key Name 난잡한 상황 개선 (#129) #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
win-luck
commented
Aug 22, 2024
Comment on lines
-24
to
42
| // 선착순 이벤트 마감 여부 tag | ||
| public static String endFlagFormatting(String key) { | ||
| return key + ":end"; | ||
| return formatKey(key, "end"); | ||
| } | ||
|
|
||
| // 선착순 이벤트 당첨자 tag | ||
| public static String winnerFormatting(String key) { | ||
| return key + ":winner"; | ||
| return formatKey(key, "winner"); | ||
| } | ||
|
|
||
| // 선착순 이벤트 참여자 tag | ||
| public static String participantFormatting(String key) { | ||
| return key + ":participant"; | ||
| return formatKey(key, "participant"); | ||
| } | ||
|
|
||
| // 선착순 이벤트 정답 tag | ||
| public static String answerFormatting(String key) { | ||
| return key + ":answer"; | ||
| return formatKey(key, "answer"); | ||
| } | ||
|
|
||
| // 공통 로직을 처리하는 메서드 | ||
| private static String formatKey(String key, String suffix) { | ||
| return FCFS_PREFIX + key + ":" + suffix; | ||
| } |
There was a problem hiding this comment.
기존의 key는 [숫자]:[역할]로 구성되어 확장성이 떨어졌기에, 별도의 PREFIX를 추가하여 의미를 명확하게 하고자 했습니다.
Comment on lines
-14
to
17
| // 선착순 이벤트 tag | ||
| public static String keyFormatting(String key) { | ||
| return key + ":fcfs"; | ||
| return formatKey(key, "count"); | ||
| } |
There was a problem hiding this comment.
한편, 기존 2:fcfs 형태의 key는 참여 가능한 사람 수를 저장하는 용도였는데, fcfs:2:fcfs와 같은 어색한 표현을 피하고자 count로 명확하게 수정했습니다.
blaxsior
reviewed
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관 이슈
📝 작업 내용
참고 이미지 및 자료
💬 리뷰 요구사항