[fix] 이벤트 유저 수가 0명일 때 set 기반 추첨을 진행하면 예외가 발생하는 문제 수정(#153) #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaxsior
commented
Aug 23, 2024
| if (count - maxPickCount <= 10 || // 두 값 차이가 작을 때 | ||
| // pick count = 0이면 아무 것도 안하게 수정 | ||
| if(maxPickCount == 0) return Collections.emptyList(); | ||
| if (count - maxPickCount <= 10 ||// 두 값 차이가 작을 때 | ||
| ((double) count / maxPickCount) <= 1.1 ) { |
There was a problem hiding this comment.
10d / 0이 exception이 나는게 아니라 infinity가 된다고 하네요. devide 0 예외가 아니라 다른 것으로 간주하는 것은 처음 알았습니다.
blaxsior
commented
Aug 23, 2024
| @@ -50,6 +51,7 @@ protected List<PickTarget> pickManyUsingSet(List<PickTarget> targets, long count | |||
| // 가중합 배열 | |||
| RandomItem[] items = getAccumulatedItems(targets); | |||
| List<PickTarget> pickedTargets = new ArrayList<>(); | |||
| if(items.length == 0) return pickedTargets; | |||
There was a problem hiding this comment.
길이가 0일 때는 바로 배열을 반환하도록 하여 방어적으로 변경했습니다.
win-luck
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관 이슈
📝 작업 내용