Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

support all architectures #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stiltskincode
Copy link
Contributor

@stiltskincode stiltskincode commented Jul 7, 2021

This is a proposal for changes.

  1. I had problem with terraform and caches. I couldn't use local version of plugin. After upgrade terraform to 1.x.x version, problem disappeared. I added the validator in Makefile for terraform and a version. This is a proposal, and we can also remove it, but If you agree with the proposal I believe this code can be much nicer :) I don't have too much practice in GNU Make
  2. Another feature what I have added is a architecture "calculations" for terraform. This system only saved plugin for linux and amd64 what isn't work for mac and osx. Now make file can check architecture for terraform and save provider in a correct directory. I decided to go in this way because I believe directory in terraform.d is similar what they shows with command
    terraform -v

image

If you agree with this solutions, I will try to improve code In Makefile and also I will update Readme. There is a minor lack of information in readme. I think you cannot do terraform apply if you didn't execute terraform init before (also I will add it)

@stiltskincode
Copy link
Contributor Author

stiltskincode commented Jul 7, 2021

Also I think we can go with these features as a optional. For instance, instead of "throwing" an error if terraform doesn't exist we can just show an information how to install and so on.

Copy link
Contributor

@Cosiek Cosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants