fix(http): transformers must be defined within the provider

softmonkeyjapan · Aug 29, 2018 · c39a864 · c39a864
1 parent d6b441a
commit c39a864
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 31 deletions.
diff --git a/dist/simple-resource.js b/dist/simple-resource.js
@@ -91,11 +91,13 @@
       'SimplePaginator'
     ])
     .provider('SimpleResourceSettings', function () {
-      this.apiUrl = undefined
+      this.apiUrl = this.transformResponse = this.transformRequest = undefined
 
       this.$get = function () {
         return {
           apiUrl: this.apiUrl,
+          transformResponse: this.transformResponse,
+          transformRequest: this.transformRequest
         }
       }
 
@@ -132,7 +134,7 @@
 
         var defaults = {
           query:   { method: 'GET', isArray: true, transformResponse: transformResponse },
-          get:     { method: 'GET' },
+          get:     { method: 'GET',   transformResponse: transformResponse },
           create:  { method: 'POST',  transformRequest: transformRequest },
           update:  { method: 'PATCH', transformRequest: transformRequest },
           destroy: { method: 'DELETE' }
@@ -210,6 +212,30 @@
     }])
 })();
 
+(function () {
+  angular
+    .module('SimpleResource')
+    .service('SRHelper', SRHelper)
+
+  function SRHelper () {
+    var service = {
+      isNumeric: isNumeric
+    }
+
+    return service
+
+    /**
+     * Check whether an object is a number.
+     *
+     * @param  {Object} object - Object to check numericallity on.
+     * @return {Boolean} True if number, false otherwise.
+     */
+    function isNumeric (object) {
+      return !isNaN(parseFloat(object)) && isFinite(object);
+    }
+  }
+})();
+
 (function () {
   SRInterceptor.$inject = ["SimpleResourceSettings", "SimplePaginator"];
   angular
@@ -285,31 +311,6 @@
   }
 })();
 
-(function () {
-  SRHelper.$inject = ["inflector"];
-  angular
-    .module('SimpleResource')
-    .service('SRHelper', SRHelper)
-
-  function SRHelper (inflector) {
-    var service = {
-      isNumeric: isNumeric
-    }
-
-    return service
-
-    /**
-     * Check whether an object is a number.
-     *
-     * @param  {Object} object - Object to check numericallity on.
-     * @return {Boolean} True if number, false otherwise.
-     */
-    function isNumeric (object) {
-      return !isNaN(parseFloat(object)) && isFinite(object);
-    }
-  }
-})();
-
 (function () {
   SRParameters.$inject = ["inflector", "SimpleResourceSettings"];
   angular

diff --git a/dist/simple-resource.min.js b/dist/simple-resource.min.js
diff --git a/lib/simple-resource/helpers/helper.js b/lib/simple-resource/helpers/helper.js
@@ -3,7 +3,7 @@
     .module('SimpleResource')
     .service('SRHelper', SRHelper)
 
-  function SRHelper (inflector) {
+  function SRHelper () {
     var service = {
       isNumeric: isNumeric
     }

diff --git a/lib/simple-resource/simple-resource.js b/lib/simple-resource/simple-resource.js
@@ -6,11 +6,13 @@
       'SimplePaginator'
     ])
     .provider('SimpleResourceSettings', function () {
-      this.apiUrl = undefined
+      this.apiUrl = this.transformResponse = this.transformRequest = undefined
 
       this.$get = function () {
         return {
           apiUrl: this.apiUrl,
+          transformResponse: this.transformResponse,
+          transformRequest: this.transformRequest
         }
       }
 
@@ -47,7 +49,7 @@
 
         var defaults = {
           query:   { method: 'GET', isArray: true, transformResponse: transformResponse },
-          get:     { method: 'GET' },
+          get:     { method: 'GET',   transformResponse: transformResponse },
           create:  { method: 'POST',  transformRequest: transformRequest },
           update:  { method: 'PATCH', transformRequest: transformRequest },
           destroy: { method: 'DELETE' }