-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Console logs #846
Enhance Console logs #846
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments inline.
What I don't see how this PR addresses which was one of the main motivators for doing this is how do we deal with large strings. Is it entirely handled by the imported methods from vscode-js-debug?
); | ||
} | ||
|
||
if (args.filter !== "indexed" && args.filter !== "named") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this should be an else if
given we exclude "indexed" here. Also what happens when "named" is used as this doesn't seem to be handled at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in: 5c1db41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Co-authored-by: Krzysztof Magiera <[email protected]>
This PR fixes an issue that occurred on fresh clones of the repository. In #846 we added a new submodule `vscode-js-debug` along with preinstall actions that should build it. This PR adds initialization to that flow so the command works on fresh clones as well. ### How Has This Been Tested: run: - `git clone [email protected]:software-mansion/radon-ide.git` - `cd packages/vscode-extension` - `npm i` everything should work
This PR aims to improve the debugging experience by making it similar to Chrome DevTools.
It improves the preview, formatting and truncating of console logs and splits large arrays into smaller changes, where chunks are fetched on expand - similarly as
vscode-js-debug
does. The more detailed previews are generated based onpreview
property from the debugger, so it may not work on older RN versions.The main idea was not to reinvent the wheel but to reuse as much of https://github.com/microsoft/vscode-js-debug as possible. Thus we forked it with small patch software-mansion-labs/vscode-js-debug@a579416 that allows us to build it - otherwise the TS on our side failed.
vscode-js-debug
sits in our repo as a git submodule and no additional steps should be necessary (preinstall script should take care of pulling it, installing and building).How Has This Been Tested:
Update
printLogs
method with:Tested on react-native-76, react-native-73.